Skip to content

Conversation

@kpassapk
Copy link

@kpassapk kpassapk commented Jun 8, 2024

Great library!

This configuration helps clj-kondo understand the defworkflow and defactivity macros.

Let me know if you have better ideas on how to organize the resources path. I thought dev/user.clj, dev/utils.clj and dev/resources kinda made sense.

@ghaskins
Copy link
Contributor

Hi,

Thanks for the patch, and sorry for the delay in responding. I somehow missed the notification from GH.

I'm curious about why you moved the dev-resources files. I generally use them in all of my projects since they are in the path by default. Does this cause a problem with clj-kondo?

@kpassapk
Copy link
Author

kpassapk commented Jun 22, 2024

Ah, I didn't know it was a special directory name. I can see now that Leiningen adds it to the resource paths automatically. I'm six months into Clojure, and have only been using tools.deps until now.

It doesn't cause a problem with clj-kondo. I have seen other tools.deps projects using dev and I thought dev/resources sounded better than dev-resources/resources.

How about this? (nb: also using io.github.manetu as directory name)

dev-resources/resources/clj-kondo/clj-kondo.exports/io.github.manetu/temporal-sdk/config.edn

@ghaskins
Copy link
Contributor

That seems reasonable to me.

Signed-off-by: Kyle Passarelli <[email protected]>
@kpassapk
Copy link
Author

kpassapk commented Jun 23, 2024

I found a list of projects which have added similar exports here. The done thing seems to be to use the (top-level) resources directory, even in projects with no other resource. (See helix).

I went ahead and replicated the style used here, leaving the dev-resources directory alone. I can confirm it works on a couple of projects. LMK.

@ghaskins
Copy link
Contributor

Code looks fine. I'm not sure what's up with CI. I might have to tweak something there.

@ghaskins
Copy link
Contributor

Note that I submitted an MR recently, and it successfully ran through CI. I am not sure why yours isn't

@kpassapk
Copy link
Author

I think this is due to circleci configuration on my side. I created #62 with the same code and it passes. Closing this one.

@kpassapk kpassapk closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants