-
Notifications
You must be signed in to change notification settings - Fork 18
Add clj-kondo exports #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, Thanks for the patch, and sorry for the delay in responding. I somehow missed the notification from GH. I'm curious about why you moved the dev-resources files. I generally use them in all of my projects since they are in the path by default. Does this cause a problem with clj-kondo? |
|
Ah, I didn't know it was a special directory name. I can see now that Leiningen adds it to the resource paths automatically. I'm six months into Clojure, and have only been using tools.deps until now. It doesn't cause a problem with clj-kondo. I have seen other tools.deps projects using How about this? (nb: also using io.github.manetu as directory name) |
|
That seems reasonable to me. |
Signed-off-by: Kyle Passarelli <[email protected]>
|
I found a list of projects which have added similar exports here. The done thing seems to be to use the (top-level) resources directory, even in projects with no other resource. (See helix). I went ahead and replicated the style used here, leaving the dev-resources directory alone. I can confirm it works on a couple of projects. LMK. |
|
Code looks fine. I'm not sure what's up with CI. I might have to tweak something there. |
|
Note that I submitted an MR recently, and it successfully ran through CI. I am not sure why yours isn't |
|
I think this is due to circleci configuration on my side. I created #62 with the same code and it passes. Closing this one. |
Great library!
This configuration helps clj-kondo understand the
defworkflowanddefactivitymacros.Let me know if you have better ideas on how to organize the resources path. I thought
dev/user.clj,dev/utils.cljanddev/resourceskinda made sense.